scrtlabs / SecretNetwork

𝕊 The Secret Network
https://scrt.network
Other
519 stars 190 forks source link

Test contract state after failing submsg #1540

Closed eshelB closed 8 months ago

eshelB commented 10 months ago

I wanted to make sure that submessages in contracts behave in the way stated by cosmwasm, in particular that the state of a contract A is saved even if it issues a submessage to contract B, which fails. only contract B's state should be reverted (edit: as long as the caller handles the reply). There was no such test so I added one. The flow of the test is as follows: (contract:message)

  1. A:increment_and_send_submessage() # increments internal counter, sends quick_fail submessage to A
  2. A:quick_fail() # increments internal counter, fails.
  3. A:reply # returns internal counter in response data the response should be the original counter incremented by 1, as the first increment should take effect, but not the second one.

Edit: Second case: No handling of reply Now the final result should be that of the submessage so everything should revert. But the revert of the main call does not happen in tests, because we create our own keeper. we check for presence of error, which tells sdk to revert in reality.