search

scrtlabs / SecretNetwork

𝕊 The Secret Network
https://scrt.network
Other
519 stars 190 forks source link

Add admin to WasmMsg::Instantiate (v1.12) #1546

Closed luca992 closed 10 months ago

luca992 commented 10 months ago

I don't have a setup that allows me to build this on arm64 but I am guessing this is the issue? @assafmo

Related: https://github.com/scrtlabs/cosmwasm/pull/25

assafmo commented 10 months ago

Yes! And also here https://github.com/scrtlabs/SecretNetwork/blob/d37dfbc758d65bf5ee90a177e4d3ea9858498d10/go-cosmwasm/types/v010/msg_v010.go#L147-L161 should fix the issue

luca992 commented 10 months ago

Added a param there. But I'm guessing some other work needs to be done in lib.go however, I really don't even know go.. I'll have to let you guys handle that haha. Feel free to trash this pr if you want, I just was pointing out where I thought needed to be fixed

assafmo commented 10 months ago

Thanks! We'll take it from here :hearts:

assafmo commented 10 months ago

https://forum.scrt.network/t/an-update-on-bugs-with-the-v1-11-upgrade/7107

assafmo commented 10 months ago

Continued in #1552