search

scrtlabs / catalyst

An Algorithmic Trading Library for Crypto-Assets in Python
http://enigma.co
Apache License 2.0
2.49k stars 723 forks source link

Bitfinex down = catalyst down #285

Open WPsites opened 6 years ago

WPsites commented 6 years ago

What can we do about this reliance on the bitfinex system even if we are just running locally or using other exchanges for trading/testing?

lenak25 commented 6 years ago

Hi @WPsites, you are correct. It is due to the benchmark data retrieved from Bitfinex. We need to add the ability to choose a different benchmark data and we plan to revise it very soon.
Thanks for reporting.

WPsites commented 6 years ago

For now I just manually edited to revert this commit and go back to using Poloniex!

https://github.com/enigmampc/catalyst/commit/cf6c3bb76b336e3d3c16c7b47bc3ef164f7f9ef3

Yes would either be better if you could override the exchange easily or even if rather than hard coded instead the benchmark data would come from which ever exchange you are working against.

lenak25 commented 6 years ago

I see, thanks for your feedback, we will consider this when addressing the benchmark improvements.

AvishaiW commented 6 years ago

I added a temporary fix for this yesterday on the develop branch, please update if it works for you or not.