scrtlabs / catalyst

An Algorithmic Trading Library for Crypto-Assets in Python
http://enigma.co
Apache License 2.0
2.49k stars 725 forks source link

Unable to start live trading in 0.5.10 (paper and real trading) #330

Closed SOGorman35 closed 6 years ago

SOGorman35 commented 6 years ago

Dear Catalyst Maintainers,

Before I tell you about my issue, let me describe my environment:

Environment

Now that you know a little about me, let me tell you about the issue I am having:

Description of Issue

Attempted to start live trading (first as paper, then double checked with real trading), and received the following error:

Traceback (most recent call last): File "c:\users\sogor\miniconda2\envs\catalyst\lib\runpy.py", line 174, in _run_module_as_main "main", fname, loader, pkg_name) File "c:\users\sogor\miniconda2\envs\catalyst\lib\runpy.py", line 72, in _run_code exec code in run_globals File "C:\Users\sogor\Miniconda2\envs\catalyst\Scripts\catalyst.exe__main.py", line 9, in File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\core.py", line 722, in call return self.main(args, kwargs) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\core.py", line 697, in main rv = self.invoke(ctx) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\core.py", line 1066, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\core.py", line 895, in invoke return ctx.invoke(self.callback, ctx.params) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\core.py", line 535, in invoke return callback(args, **kwargs) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\catalyst\main_.py", line 104, in return f(*args, *kwargs) File "c:\users\sogor\miniconda2\envs\catalyst\lib\site-packages\click\decorators.py", line 17, in new_func return f(get_current_context(), args, **kwargs) TypeError: live() got an unexpected keyword argument 'start'

Live/simulated trading to begin.

The error message listed above. No changes have been made to anything else beyond upgrading to 0.5.10. Live trading worked in 0.5.9.

Here is how you can reproduce this issue on your machine:

Reproduction Steps

  1. Attempt to run catalyst live [additional parameters]

Anything else?

I did some backtesting in Jupyter, and it still works fine.

...

Sincerely, Sean

lenak25 commented 6 years ago

Hi @SOGorman35 , thanks for reporting!

Could you please share the run command you are using \ run_algorithm function definition?

Thanks!

SOGorman35 commented 6 years ago

I run from the command line. An example (specifics removed for privacy) would be:

catalyst live -f sample.py -x exchange -c btc --capital-base 1 -n sample_output.

If it was real money trading, I'd also add --no-simulate-orders --auth-aliases exchange,auth

Hopefully I'm not forgetting anything in there.

AvishaiW commented 6 years ago

Hi, The bug was fixed and we released a new version (0.5.11). Thanks for pointing it out!