search

scrtlabs / discovery-docker-network

Docker Network for the Discovery release of the Enigma Protocol
https://enigma.co
GNU Affero General Public License v3.0
21 stars 2 forks source link

Wrong parameters in Deployment of contract results in `unreachable` #9

Open lacabra opened 5 years ago

lacabra commented 5 years ago

Describe the bug Deploying a secret contract on the network passing a wrong set of parameters to the constructor results in an error in deployment reported as 

core_1       | Error in deployment of smart contract function: Error in execution of WASM code: unreachable
core_1       | 17:54:42 [INFO] LOG DERIVE: Ok(FailedTask { result: FailedTask { output: "7bab741bea22ea9ce914ec7800481b503969936e4a1e32af810a6aa12f939fe2dff09482ef1e8081e811e934f0753ebcd1c2e9d04717cd27038ebe3e9af5c8ca4b4a4bb163c3d396", used_gas: 963, signature: "408c5fa05d4842049cc10350f460aa5bfbb488c65fa134b5e9dcc98df95d842f1c217d3d0e7933d28f2cb8094182067952a206dd48443e2687ffd8ded4d061e01c" } })

Note: this is a follow up to Issue 117 in core

To Reproduce Steps to reproduce the behavior:

  1. Launch the network
  2. Run the following tests: 
    01_init.spec.js
03_deploy_fail_parameters.spec.js

Expected behavior I would expect an error that would explicitly say something about the wrong set of parameters.

Otherwise confirm that this the desired behavior.

moriaab commented 5 years ago

This was already identified as core error. See https://github.com/enigmampc/enigma-core/issues/128, including @moriaab comment. (@lacabra)