search

scrtlabs / enigma-p2p

The Enigma Worker Peer-to-Peer (P2P) package written in Node.js based on libp2p-js
https://enigma.co/protocol/
GNU Affero General Public License v3.0
38 stars 4 forks source link

Logout on crash #260

Closed assafmo closed 4 years ago

assafmo commented 4 years ago

Please merge after #259

assafmo commented 4 years ago

Also need to talk with Itzik about this

assafmo commented 4 years ago

After a discussion with @lenak25 & @Cashmaney we decided to do nothing on error and just exit.
The supervisor will restart the node immediately.
In case of a docker-compose down the supervisor will logout, and for that we'll add a --logout-and-exit CLI flag.

codecov[bot] commented 4 years ago

Codecov Report

Merging #260 into develop will decrease coverage by 0.07%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    75.74%   75.67%   -0.08%     
===========================================
  Files          103      103              
  Lines         4985     4990       +5     
===========================================
  Hits          3776     3776              
- Misses        1209     1214       +5
Impacted Files Coverage Δ
...worker/controller/actions/ethereum/LogoutAction.js 11.53% <0%> (-2.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31c3d88...ce211de. Read the comment docs.