scrtlabs / enigma-p2p

The Enigma Worker Peer-to-Peer (P2P) package written in Node.js based on libp2p-js
https://enigma.co/protocol/
GNU Affero General Public License v3.0
38 stars 4 forks source link

Selection algorithm only on consensus level #261

Closed assafmo closed 4 years ago

assafmo commented 4 years ago

Always use the consensus level (Ethereum) selection algorithm for assigning tasks.
Remove local implementation.

codecov[bot] commented 4 years ago

Codecov Report

Merging #261 into develop will decrease coverage by 27.62%. The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #261       +/-   ##
============================================
- Coverage    78.85%   51.22%   -27.63%     
============================================
  Files          102      100        -2     
  Lines         4743     4658       -85     
============================================
- Hits          3740     2386     -1354     
- Misses        1003     2272     +1269
Impacted Files Coverage Δ
src/ethereum/EnigmaContractReaderAPI.js 48.22% <0%> (-9.45%) :arrow_down:
src/ethereum/EthereumVerifier.js 48.63% <96%> (-42.8%) :arrow_down:
...worker/state_sync/receiver/StateSyncReqVerifier.js 10% <0%> (-90%) :arrow_down:
src/common/DbUtils.js 13.79% <0%> (-82.76%) :arrow_down:
src/db/StateCache.js 8.82% <0%> (-82.36%) :arrow_down:
src/worker/controller/actions/HealthCheckAction.js 10.71% <0%> (-82.15%) :arrow_down:
...er/state_sync/receiver/LocalMissingStatesResult.js 10% <0%> (-80%) :arrow_down:
...ker/controller/actions/sync/TryReceiveAllAction.js 12.9% <0%> (-79.41%) :arrow_down:
...ntroller/actions/ethereum/GetWorkerParamsAction.js 11.11% <0%> (-77.78%) :arrow_down:
...rker/controller/actions/ethereum/RegisterAction.js 11.53% <0%> (-76.93%) :arrow_down:
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 987a7f7...60ae625. Read the comment docs.

assafmo commented 4 years ago

Two integration tests are failing for some reason: Screenshot from 2019-12-18 11-39-11

I'm trying to debug them locally with the help of @lacabra.