search

scrtlabs / enigma-p2p

The Enigma Worker Peer-to-Peer (P2P) package written in Node.js based on libp2p-js
https://enigma.co/protocol/
GNU Affero General Public License v3.0
38 stars 4 forks source link

Sign Ethereum transactions using chainId #279

Closed assafmo closed 4 years ago

assafmo commented 4 years ago

For reference: https://github.com/ethereum/web3.js/issues/1326 https://github.com/ethereum/web3.js/issues/526#issuecomment-386577414

codecov[bot] commented 4 years ago

Codecov Report

Merging #279 into develop will increase coverage by 0.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
+ Coverage    77.47%   77.49%   +0.01%     
===========================================
  Files          103      103              
  Lines         4915     4919       +4     
===========================================
+ Hits          3808     3812       +4     
  Misses        1107     1107
Impacted Files Coverage Δ
src/ethereum/EnigmaContractProductionWriterAPI.js 80.53% <100%> (ø) :arrow_up:
src/ethereum/EnigmaContractReaderAPI.js 57.67% <80%> (+0.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49338f6...b0c74c2. Read the comment docs.