search

scrtlabs / enigma-p2p

The Enigma Worker Peer-to-Peer (P2P) package written in Node.js based on libp2p-js
https://enigma.co/protocol/
GNU Affero General Public License v3.0
38 stars 4 forks source link

Ethereum API Better Event Handling (filter by indexed taskId) #282

Closed assafmo closed 4 years ago

assafmo commented 4 years ago

This PR is related to: https://github.com/enigmampc/enigma-contract/pull/174 https://github.com/enigmampc/integration-tests/pull/9

And continues: https://github.com/enigmampc/enigma-p2p/pull/252

assafmo commented 4 years ago

@lenak25 This also happens to me in the unrelated https://github.com/enigmampc/enigma-p2p/pull/261, so I am truly puzzled right now. :sleepy: :thinking:

Screenshot from 2019-12-23 09-56-34

codecov[bot] commented 4 years ago

Codecov Report

Merging #282 into develop will decrease coverage by 0.01%. The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #282      +/-   ##
===========================================
- Coverage    78.85%   78.84%   -0.02%     
===========================================
  Files          102      102              
  Lines         4743     4736       -7     
===========================================
- Hits          3740     3734       -6     
+ Misses        1003     1002       -1
Impacted Files Coverage Δ
src/ethereum/EnigmaContractReaderAPI.js 57.67% <ø> (ø) :arrow_up:
src/client_api/JsonRpcServer.js 90.36% <100%> (+0.11%) :arrow_up:
src/ethereum/EnigmaContractWriterAPI.js 79.14% <91.66%> (-0.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 987a7f7...3c2bf1a. Read the comment docs.

assafmo commented 4 years ago

@lenak25 I've addressed all of your comments. :100: