scrtlabs / enigma-p2p

The Enigma Worker Peer-to-Peer (P2P) package written in Node.js based on libp2p-js
https://enigma.co/protocol/
GNU Affero General Public License v3.0
38 stars 4 forks source link

Refactor .drone.yml #289

Closed assafmo closed 4 years ago

assafmo commented 4 years ago

Matching PRs: https://github.com/enigmampc/enigma-core/pull/279 https://github.com/enigmampc/enigma-contract/pull/198

codecov[bot] commented 4 years ago

Codecov Report

Merging #289 into develop will decrease coverage by 0.03%. The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #289      +/-   ##
===========================================
- Coverage    77.38%   77.34%   -0.04%     
===========================================
  Files          104      104              
  Lines         4781     4777       -4     
===========================================
- Hits          3700     3695       -5     
- Misses        1081     1082       +1
Impacted Files Coverage Δ
...ontroller/actions/tasks/PublishTaskResultAction.js 81.81% <100%> (ø) :arrow_up:
...ontroller/actions/sync/AnnounceLocalStateAction.js 71.42% <100%> (+0.59%) :arrow_up:
...r/controller/actions/sync/AnnounceContentAction.js 62.96% <18.18%> (-10.12%) :arrow_down:
src/worker/state_sync/provider/Provider.js 86.66% <75%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 948b02d...1f80286. Read the comment docs.

assafmo commented 4 years ago

@lenak25 Ready for your review 🦄

lacabra commented 4 years ago

@assafmo I warn about modifying .drone.yml "unilaterally" in one repo only. Right now, the drone files in the three main repos are all analogous and very similar, so that they are easy to maintain. @reuvenpo and I led the work on these files that got us to where we are. I would ask a review from either or both of us before merging this, when you feel this is ready.

lacabra commented 4 years ago

@assafmo In the latest build, all the integration tests pass, the 4th worker inits successfully, see this link, L12338:

worker_4     | 2020-01-23T19:57:40Z INFO [P2P-MainController] - success InitWorkerAction

but there is never a success syncing pipeline message, so the build times out and errors out.