`signAmino()`: use `memo` from signed transaction instead of from the caller

scrtlabs / secret.js

The JavaScript SDK for Secret Network

https://secretjs.scrt.network

MIT License

74 stars 36 forks source link

`signAmino()`: use `memo` from signed transaction instead of from the caller #163

Closed assafmo closed 6 months ago

assafmo commented 6 months ago

Fixes https://github.com/scrtlabs/secret.js/issues/161

Before now, signAmino() used memo from the caller. This made it so if the signer changed the memo before signing, the transaction would fail because of a signature mismatch.

Note: this bug only existed in signAmino() and not in signDirect().

cloudflare-workers-and-pages[bot] commented 6 months ago

Deploying secretjs-docs with Cloudflare Pages

Latest commit:	`505ef9a`
Status:	✅ Deploy successful!
Preview URL:	https://70d07fc5.secretjs-scrt-network.pages.dev
Branch Preview URL:	https://fix-signamino-memo.secretjs-scrt-network.pages.dev

View logs