Not compatible with Symfony 5

scrutinizer-ci / ocular

CLI for uploading external code coverage data

https://scrutinizer-ci.com

41 stars 24 forks source link

Not compatible with Symfony 5 #47

Closed colinodell closed 2 years ago

colinodell commented 4 years ago

PR #44 added support for installing Symfony 5 components, but this project is actually NOT compatible with symfony/process 5.x. The ability to accept a string as the first parameter of the Process constructor was deprecated in 4.2 and removed in 5.0. See the CHANGELOG for more information.

As a result, requiring version 1.7.0 of this project on newer versions of PHP leads to fatal errors like https://github.com/thephpleague/commonmark/issues/410:

peterfox commented 4 years ago

Also got this problem currently. Had to use master-dev in two packages I work on until this is resolved as Laravel now requires Symfony 5 components.

ghost commented 4 years ago

Reverted to 1.6.0 until this is fixed.

secondtruth commented 4 years ago

I've created pull request #49 to fix this. @schmittjoh

schmittjoh commented 2 years ago

Closing this as fixed a while ago.