search

scrutinizer-ci / scrutinizer

Legacy repository - archives past feature requests/bug reports
https://scrutinizer-ci.com/docs
139 stars 35 forks source link

The coverage badge gives a wrong score #123

Open stof opened 10 years ago

stof commented 10 years ago

Looking at https://scrutinizer-ci.com/g/Litipk/php-bignumbers/code-structure/hot-spots shows that the only class of the library has 100% code coverage. scrutinizer_coverage

However, the badge displayed on the main page shows 74% coverage: scrutinizer_badges

schmittjoh commented 10 years ago

There is probably some code which is outside of a class/method.

On Thu, Jan 30, 2014 at 11:05 AM, Christophe Coevoet < notifications@github.com> wrote:

Looking at https://scrutinizer-ci.com/g/Litipk/php-bignumbers/code-structure/hot-spotsshows that the only class of the library has 100% code coverage. [image: scrutinizer_coverage]https://f.cloud.github.com/assets/439401/2038886/01fad97a-8996-11e3-9448-1e62a823f351.PNG

However, the badge displayed on the main pagehttps://scrutinizer-ci.com/g/Litipk/php-bignumbers/shows 74% coverage: [image: scrutinizer_badges]https://f.cloud.github.com/assets/439401/2038890/11f114ac-8996-11e3-9766-1c11e3848e05.PNG

Reply to this email directly or view it on GitHubhttps://github.com/scrutinizer-ci/scrutinizer/issues/123 .

schmittjoh commented 10 years ago

The problem is what I described above. The overall percentage is currently computed by PHP Code Coverage which includes all files that you told it via the configuration.

We could however, compute this ourselves by just using the class coverages. That way, the overall percentage would always include the code which is in a class/function/method. This is probably what most people want.