search

scrutinizer-ci / scrutinizer

Legacy repository - archives past feature requests/bug reports
https://scrutinizer-ci.com/docs
140 stars 36 forks source link

GitHub: link to TravisCI gets hijacked #170

Closed JeroenDeDauw closed 9 years ago

JeroenDeDauw commented 10 years ago

When using Scrutinizer, the build status icon (the one that states one of: passed, failed, error) links to ScrutinizerCI rather than to TravisCI. It's nice to have a link to ScrutinizerCI, though for my team the choice goes to TravisCI if we need to pick one. That is where we want to go when a build fails after all.

aik099 commented 10 years ago

Here is screenshot with my ideas: github_pr_scrutinizertravis_details

// cc: @stof

JeroenDeDauw commented 10 years ago

@addshore @tobijat

stof commented 10 years ago

@aik099 there is a single details link, because Github does not support combined statuses in their UI (they support it in their API only since a few days, and it is still beta). The details are for the status, which is set by Scrutinizer here. If doing it the dumb way, the travis status would be lost entirely. Scrutinizer currently builds the combined status by itself, and then put a link to Travis in its own page.

A status can only have a single url. Look at the Github API. You are confusing what is build by Scuritnizer (the string Scrutinizer: 2 added/modified code elements -- Travis: Failed), and what is build by github.

The only way to have a better UX for statuses is to wait for github to provide the combined status themselves in the PR page. See https://twitter.com/GitHubAPI/status/449232149963898880 for a discussion about it a few days ago. It is likely to come when the combined status comes out of beta

schmittjoh commented 10 years ago

What you can do in the meantime is switch to have Scrutinizer comment on pull requests instead of using the status.

JeroenDeDauw commented 10 years ago

What you can do in the meantime is switch to have Scrutinizer comment on pull requests instead of using the status.

Is this a suggestion for changes to Scrutinizer or something users can do via config?

schmittjoh commented 10 years ago

You can already do this in your repository configuration under "Pull-Request Notification".

JeroenDeDauw commented 10 years ago

You can already do this in your repository configuration under "Pull-Request Notification".

Cool. Doing this now for a few repos. Still awaiting default behaviour to get fixed, as I do not want to go through ALL my repos and change the config.

schmittjoh commented 10 years ago

The default behavior is to either set things to success or the status that another service has set, or failed if you specify build failure conditions and link to the other services.

I'm not sure how we can do better here until GitHub natively supports merging the status.

Anahkiasen commented 10 years ago

Doesn't Github now support multiple status or something with the latest API update ?

schmittjoh commented 10 years ago

Not yet, unfortunately. They gather the data which is a good start, but they have not yet built the UI around it.

tonglil commented 9 years ago

I am fairly certain this issue is now resolved by Github.

JeroenDeDauw commented 9 years ago

Yeah, it indeed has been resolved