scrutinizer-ci / scrutinizer

Legacy repository - archives past feature requests/bug reports
https://scrutinizer-ci.com/docs
140 stars 36 forks source link

"Please declare explicit visibility" Coding Style warning on property that already has explicit visibility private #253

Open wimvds opened 10 years ago

wimvds commented 10 years ago

I think it's a bit weird to get the "Please declare explicit visibility instead of using a prefixed underscore." Coding Style warning on a property that has explicit visibility defined (private)...

see Issue (Id: PSR2.Classes.PropertyDeclaration.Underscore)

aik099 commented 10 years ago

@wimvds , any error message text in mind that current one can be replaced with.

wimvds commented 10 years ago

I think this shouldn't be triggered on properties that have explicit visibility (public/protected/private) defined, ie. only on those defined as "var $_SOMETHING"?

aik099 commented 10 years ago

Here Scrutinizer is just following PSR-2 standard which says, that no class members can be prefixed with underscore.

schmittjoh commented 10 years ago

I think it would probably make sense to ignore this as @wimvds suggested. It does not seem to add value.

aik099 commented 10 years ago

Ok.