Open wimvds opened 10 years ago
@wimvds , any error message text in mind that current one can be replaced with.
I think this shouldn't be triggered on properties that have explicit visibility (public/protected/private) defined, ie. only on those defined as "var $_SOMETHING"?
Here Scrutinizer is just following PSR-2 standard which says, that no class members can be prefixed with underscore.
I think it would probably make sense to ignore this as @wimvds suggested. It does not seem to add value.
Ok.
I think it's a bit weird to get the "Please declare explicit visibility instead of using a prefixed underscore." Coding Style warning on a property that has explicit visibility defined (private)...
see Issue (Id: PSR2.Classes.PropertyDeclaration.Underscore)