scrutinizer-ci / scrutinizer

Legacy repository - archives past feature requests/bug reports
https://scrutinizer-ci.com/docs
140 stars 36 forks source link

Detection of abstract methods in traits not completely resolved via other traits #255

Open ghost opened 10 years ago

ghost commented 10 years ago

In my class, I use two traits:

  1. declares abstract methods
  2. implements abstract methods

The inspection only seems to be aware of the declarations but not the implementations.

see Issue (Id: basic_semantics.abstract_method_on_non_abstract_class)

schmittjoh commented 10 years ago

Could you elaborate this a bit more. You seem to have changed the code since creating this, and the issues seem to be gone now.

ghost commented 10 years ago

I have a class that makes use of two separate traits. One trait provides its own methods, but also adds abstract methods that are expected to be implemented by the class the trait is used in. The other trait implements those abstract methods.

This works fine in PHP, but it looks like Scrutinizer is not aware of the abstract methods being implemented in the other trait.

schmittjoh commented 10 years ago

Ah, I see, makes sense.