search

scrutinizer-ci / scrutinizer

Legacy repository - archives past feature requests/bug reports
https://scrutinizer-ci.com/docs
140 stars 36 forks source link

False positive code duplication still influencing method rating #301

Open Anahkiasen opened 9 years ago

Anahkiasen commented 9 years ago

I have this method who has a code duplication marked as false positive. Despite this being the only issue, the method and class are still rated D.

Anahkiasen commented 9 years ago

(Link to the actual class and rating https://scrutinizer-ci.com/g/madewithlove/remindme/code-structure/develop/operation/Remindme%5CHttp%5CControllers%5CTopicsController%3A%3AupdateEmotionCustom )

yoosefi commented 9 years ago

:+1: same

NinoFloris commented 8 years ago

Seems like you are not allowed to influence your score. Should be the author knows best right? Why all the handholding. Duplication errors are especially annoying in traits as you want to add as little extra methods and sometimes this means you duplicate a few lines. Again programmer/author knows best.

https://gina4star.files.wordpress.com/2013/10/computer-says-no-490x275.jpg "Computer says no"

yoosefi commented 8 years ago

I don't see this as much "influencing my score" as I see it as "the duplication check is fascist".

I have two different methods, that do two different things, and simply because the arguments I pass to them are built similarly, it gets marked as "duplicate".

:8ball:

tarlepp commented 6 years ago

@yoosefi same here, is there any plans to solve this?