search

scsoccer / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #5

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations

In this first project, I look at two primary items with the main goal being to stop inefficient or bad practices early.

First, did you use divs, ids/classes to manage and organize your HTML.

Good on this, your HTML and class usage had everything I look for.

Second is your CSS efficient and non-repetitive. CSS repetition is one of the common mistakes I see in this first project. Whenever you are repeating a style, look at what options CSS offers to avoid this. Also when looking at the elements in developer tools, you do not need to copy the styles in the user agent sheet, that is the default style that is already applied.

To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.

scsoccer commented 6 years ago

Thank you so much for the feed back! Flexboxfroggy.com was very helpful!