sct-pipeline / contrast-agnostic-softseg-spinalcord

Contrast-agnostic spinal cord segmentation project with softseg
MIT License
4 stars 3 forks source link

run_inference_single_image.py v1 vs v2 #106

Closed jcohenadad closed 1 month ago

jcohenadad commented 2 months ago

is the 'non v2' file obsolete? if so can we get rid of it? If not, why do we need both versions?

image

naga-karthik commented 2 months ago

oh, actually run_inference_single_image.py is the file. The _v2 is obsolete.

This is a bigger issue (for me) -- sometimes I need to heavily modify the original inference script to do some testing. BUT, I don't want to keep it local (easier to reference it when it is pushed) and don't want to break the original inference script if someone (like yourself in this case) is using it.

SO, how to go around this issue? This is the reason I created _v2 file.

naga-karthik commented 2 months ago

okay, I realized the _v2 file is on main so it's my fault it's on the main branch! I think files like these should be in branches (i.e. experimental). I am going to remove it from main

naga-karthik commented 1 month ago

Closing as fixed by #104