search

sct-pipeline / spine-park

Pipeline for multicontrast analysis in PD patients
MIT License
0 stars 0 forks source link

Wrong use of disc labels #32

Closed jcohenadad closed 6 months ago

jcohenadad commented 6 months ago

While working on #31, I noticed an issue with the code. The disc labels are used in lieu of vertebral labels, in case manual labels are provided.

Here is what happens for manual labels: they are copied as the output:

https://github.com/sct-pipeline/spine-park/blob/cb51fb67b2763901ee3692cfe6dd792065850a0b/batch_processing.sh#L64-L73

Whereas vertebral labels should be created at label_values

And that's obviously a problem because the registration code uses vertebral-based labels, not disc ones: https://github.com/sct-pipeline/spine-park/blob/cb51fb67b2763901ee3692cfe6dd792065850a0b/batch_processing.sh#L127-L133