Server 500 error when retrieving movie/series info

firephreek commented 1 year ago

Description

Upgraded from 1.32 to 1.33 and numerous series and movies now shown as 'unavailable' despite having been previously added/requested and verified present on the associated Plex server.

Per the logs, the source the failure seems to be related to failed parsing of a JSON response and seems to happen in a variety of ways:

examples:

2023-06-20T20:32:34.620Z [debug][API]: Something went wrong retrieving series{"errorMessage":"Cannot read properties of undefined (reading 'crew')","tvId":"202099"}
2023-06-20T20:36:04.355Z [debug][API]: Something went wrong retrieving combined credits{"errorMessage":"[TMDB] Failed to fetch person combined credits: Request failed with status code 500","personId":"93396"}
2023-06-20T20:37:19.972Z [debug][API]: Something went wrong retrieving combined credits{"errorMessage":"[TMDB] Failed to fetch person combined credits: Request failed with status code 500","personId":"1958355"}
2023-06-20T20:33:02.490Z [debug][API]: Something went wrong retrieving movie{"errorMessage":"Cannot read properties of undefined (reading 'facebook_id')","movieId":"793"}

Version

1.33.0

Steps to Reproduce

Go to https://[myoverseer]/tv/82728
Get redirected to home page.

Screenshots

No response

Logs

- `2023-06-20T20:32:34.620Z [debug][API]: Something went wrong retrieving series{"errorMessage":"Cannot read properties of undefined (reading 'crew')","tvId":"202099"}`
- `2023-06-20T20:36:04.355Z [debug][API]: Something went wrong retrieving combined credits{"errorMessage":"[TMDB] Failed to fetch person combined credits: Request failed with status code 500","personId":"93396"}`
- `2023-06-20T20:37:19.972Z [debug][API]: Something went wrong retrieving combined credits{"errorMessage":"[TMDB] Failed to fetch person combined credits: Request failed with status code 500","personId":"1958355"}`
- `2023-06-20T20:33:02.490Z [debug][API]: Something went wrong retrieving movie{"errorMessage":"Cannot read properties of undefined (reading 'facebook_id')","movieId":"793"}`

Platform

desktop

Device

Browser

Operating System

Linux, Android, Mac

Browser

Firefox, Safari, Chromium

Additional Context

No response

Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

TheDeadestCow commented 1 year ago

Have the same issue. Reported on overseerr discord. It's also affecting covers of recently added as well. I do not use cache, v1.33. Using SCTX Docker container.

Skyl3lazer commented 1 year ago

Same here

xandervanerven commented 1 year ago

same issue, i tried deleting a request and readding, but just getting a 500 error when entering the series page

JiggsNephron commented 1 year ago

This seems to be an issue with TMDB's API: https://www.themoviedb.org/talk/6491f7572f8d0900c6679013

PH1L900D commented 1 year ago

Same here

firephreek commented 1 year ago

This seems to be an issue with TMDB's API: https://www.themoviedb.org/talk/6491f7572f8d0900c6679013

That there may be an issue with TMDB's API doesn't mean there isn't an issue here. The logs seem to suggest a failure in the response parsing of whatever TMDB is coming back with. More investigation is needed than what the logs currently provide. Anyone know the easiest way to find the associated call with these error messages?

Edit: Dug down into the code, found the requests, got myself an API key. I've confirmed responses using curl, API seems fine even if the results are missing properties. But a missing prop shouldn't be breaking things like this. Maybe something changed in the new release? Regression? or is there some sort of API mis-match happening?

Output attached. 793.txt 93396.txt 202099.txt 202102.txt 1958355.txt

firephreek commented 1 year ago

At least one of the problems is here in this line

...
 cast: show.aggregate_credits.cast.map(mapAggregateCast)
 crew: show.credits.crew.map(mapCrew),
...

There's no null check for child properties, so if the TMDB JSON result drops something like 'credits' or 'cast' here, map will be called on undefined, throwing errors and the models used don't have defaults built.

Percy2Live commented 1 year ago

Same problem here, even a downgrade to an earlier version of overseerr does not solve this issue

dhaos21 commented 1 year ago

This is a weird one as series it was happening to every single time yesterday are no longer doing it today, So maybe like the above user said its a TMDB API issue.

TheDeadestCow commented 1 year ago

This is also resolved for me today, but it would be great to hear fromt he devs on root cause. Was an API limit reached for the app or was this a problem at IMDB/TVDB? If ti's a limit, seems likely to happen again.

Drol commented 1 year ago

I have had this problem multiple times for a few weeks. Sometimes it goes away and then it comes back.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sct / overseerr