sct / overseerr

Request management and media discovery tool for the Plex ecosystem
https://overseerr.dev
MIT License
3.55k stars 412 forks source link

Test connection modifies settings without user content and does not tell about it #3817

Open avermatti opened 3 months ago

avermatti commented 3 months ago

Description

I recently added base url to my connected services. Operations in Overseerr failed because I didn't remember to update the base url setting in Overseerr. When I went to the settings and press test connection button it gives connection test success notification and I closed the prompt without saving. However I didn't notice at that time it altered the configuration before the test is made and therefore connection test did not use the settings I was running.

Test button should either not modify the given settings or it should alert the user to save the changes.

On initial service setup current functionality is acceptable as you're not able to save non working configuration.

Version

1.32.2

Steps to Reproduce

Configure Overseerr and it's services without base url Add base url to the running service and break everything Open service settings in Overseerr and press test Connection test success Close the prompt without saving Connection remains borken

Screenshots

No response

Logs

No response

Platform

desktop

Device

PC

Operating System

W11

Browser

Firefox

Additional Context

No response

Code of Conduct