sct / overseerr

Request management and media discovery tool for the Plex ecosystem
https://overseerr.dev
MIT License
3.78k stars 440 forks source link

Default cronjobs are incorrect. #3818

Open r-pufky opened 6 months ago

r-pufky commented 6 months ago

Description

For each cronjob setting, it seems that the "default" install settings which are impossible to reset to in the UI; this applies to all jobs. Additionally dropdowns are seemingly very restricted.

e.g. Media Availability Sync:

Default: run every day at 0500.

"availability-sync": {
    "schedule": "0 0 5 * * *",
   },

Any UI configuration: run every X hours.

"availability-sync": {
    "schedule": "0 0 */4 * * *",
   },

These default values are not encoded in the UI, and cannot be reset to defaults without manually editing settings.json or reinstalling.

Full control of the crontab should be used; or sensible defaults for each option should appear in the UI in order to:

  1. replicate the default installed options.
  2. provide reasonable option range for value being set.
  3. provide a way to enter the cronjob manually for complete control.

Version

1.33.2

Steps to Reproduce

  1. Default install / docker/snap/baremetal.
  2. Goto settings -> jobs and sync -> any job.

Screenshots

No response

Logs

No response

Platform

desktop

Device

linux

Operating System

linux

Browser

chrome

Additional Context

No response

Code of Conduct

r-netizen commented 6 months ago

"These default values are not encoded in the UI, and cannot be reset to defaults without manually editing settings.json or reinstalling." Thats not entirely true, you can always modify them using the REST API.

r-pufky commented 6 months ago

"For each cronjob setting, it seems that the "default" install settings which are impossible to reset to in the UI; this applies to all jobs. Additionally dropdowns are seemingly very restricted."

The point of the bug was that it was not addressable in the UI; regardless of manually editing settings.json or using the API.

danshilm commented 6 months ago

We opted to not add the ability to specify a cron string in the UI because that wouldn't be really user friendly, especially considering that there's a good amount of people that use Overseerr who don't know what a cron string is. And if someone wants to get fancy with it, they can put their cron string directly in the settings file or use the OpenAPI docs viewer to set it. So I don't think we'd add that.

Setting the job back to it's default schedule would be a feature request, and should be fairly easy if you'd want to make a pull request.