search

sctplab / sctp-refimpl

Automatically exported from code.google.com/p/sctp-refimpl
BSD 2-Clause "Simplified" License
8 stars 2 forks source link

Overflow with memcpy() in Win_getifaddrs() #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
sctp_userspace.c 144

struct sockaddr_in *addr;
...
addr = (struct sockaddr_in *)malloc(sizeof(struct sockaddr_in));
...
memcpy(&addr, &pAdapt->FirstUnicastAddress->Address.lpSockaddr, sizeof(struct 
sockaddr_in));

I think should be:
memcpy(addr, &pAdapt->FirstUnicastAddress->Address.lpSockaddr, sizeof(struct 
sockaddr_in));

--------------------------
Same with
#if defined(INET6)
        struct sockaddr_in6 *addr6;
#endif

Original issue reported on code.google.com by 12maks...@gmail.com on 14 Apr 2014 at 10:01

GoogleCodeExporter commented 9 years ago 
Fixed in
http://code.google.com/p/sctp-refimpl/source/detail?r=8911
Thanks for reporting the issue and providing the fix.

Original comment by t00FC...@googlemail.com on 2 Jul 2014 at 3:37