sctplab / sctp-refimpl

Automatically exported from code.google.com/p/sctp-refimpl
BSD 2-Clause "Simplified" License
8 stars 2 forks source link

libusrsctp is not building for iOS #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to compile using attached buildiOS.sh that has iOS build setup

What is the expected output? What do you see instead?
Expect library to compile, instead get an error of missing include:

In file included from user_socket.c:35:
In file included from ./netinet/sctp_os.h:72:
./netinet/sctp_os_userspace.h:491:10: fatal error: 'netinet/ip_icmp.h' file not 
found
#include <netinet/ip_icmp.h>

What version of the product are you using? On what operating system?

Latest SVN checkout as of Feb 11 2015

Please provide any additional information below.

Diff file below fixes the problem. It disables include when not using inet and 
inet6.
Also people might find handy the build script for iOs

Original issue reported on code.google.com by mrubenc...@gmail.com on 11 Feb 2015 at 6:26

Attachments:

GoogleCodeExporter commented 9 years ago
I've not tested building the code on iOS. Your suggested patch only works in 
the case when neither INET nor INET6 is used. I'm planning to come up with a 
patch that works also in the case where INET or INET6 or both are defined. 
Thanks a lot for providing the build  script.
Give me a day or so...

Best regards
Michael

Original comment by t00FC...@googlemail.com on 13 Feb 2015 at 8:29

GoogleCodeExporter commented 9 years ago
I committed a fix in
https://code.google.com/p/sctp-refimpl/source/detail?r=9167

Thanks for reporting and proving a script to reproduce the issue.

Original comment by t00FC...@googlemail.com on 16 Feb 2015 at 8:08

GoogleCodeExporter commented 9 years ago
If a fix is committed, perhaps it's time to set the issue as solved?

Original comment by haneef...@gmail.com on 2 Mar 2015 at 3:08

GoogleCodeExporter commented 9 years ago
I wanted to wait a bit to give the person reporting the issue some time to 
verify that the issue is fixed...
Closing it now.

Original comment by t00FC...@googlemail.com on 2 Mar 2015 at 7:10