search

scttcper / ngx-codemirror

Codemirror Wrapper for Angular
https://ngx-codemirror.vercel.app
MIT License
282 stars 47 forks source link

Angular v8 should be added as peerDependancy and not as dependancy #234

Closed rdandnayak closed 4 years ago

rdandnayak commented 4 years ago 
"dependencies": {
    "@angular/common": "8.2.14",
    "@angular/compiler": "8.2.14",
    "@angular/core": "8.2.14",
    "@angular/forms": "8.2.14",
    "@angular/platform-browser": "8.2.14",
    "@angular/platform-browser-dynamic": "8.2.14",
    "@ctrl/ngx-github-buttons": "3.2.7",
    "bootstrap": "4.3.1",
    "codemirror": "5.49.2",
    "core-js": "3.3.6",
    "rxjs": "6.5.3",
    "zone.js": "0.10.2"
  },

should be

  "dependencies": {
    "@angular/common": "8.2.14",
    "@angular/compiler": "8.2.14",
    "@angular/platform-browser": "8.2.14",
    "@angular/platform-browser-dynamic": "8.2.14",
    "@ctrl/ngx-github-buttons": "3.2.7",
    "bootstrap": "4.3.1",
    "codemirror": "5.49.2",
    "core-js": "3.3.6",
    "rxjs": "6.5.3",
    "zone.js": "0.10.2"
  },
  "peerDependencies": {
    "@angular/core": "^8.0.0 || ^7.0.0",
    "@angular/forms": "^8.0.0 || ^7.0.0"
  },

npm is not warning me anything about version is not compatible.

I tried raising PR but it is not allowing me

git push --set-upstream origin peer-dependancy
remote: Permission to TypeCtrl/ngx-codemirror.git denied to rdandnayak.
fatal: unable to access 'https://github.com/TypeCtrl/ngx-codemirror.git/': The requested URL returned error: 403
scttcper commented 4 years ago

these are the dependencies on publish https://github.com/TypeCtrl/ngx-codemirror/blob/master/src/lib/package.json#L10-L14