jpevarnek commented 4 years ago

The current var CodeMirror statement is creating a new variable in this file that is never being set. Based on comments, it appears that the original intention is to access the global variable we get from pulling in the CodeMirror library. This updates it to use the syntax for declaring an external variable.

codecov[bot] commented 4 years ago

Codecov Report

Merging #264 into master will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   29.70%   29.70%           
=======================================
  Files           5        5           
  Lines         101      101           
  Branches       15       15           
=======================================
  Hits           30       30           
  Misses         71       71

Impacted Files	Coverage Δ
src/lib/codemirror.component.ts	`20.93% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92a125f...b431d76. Read the comment docs.

scttcper commented 4 years ago

:tada: This PR is included in version 3.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

scttcper / ngx-codemirror

fix: Declare CodeMirror as external variable #264

Codecov Report