search

scttcper / ngx-emoji-mart

Customizable Slack-like emoji picker for Angular
https://ngx-emoji-mart.vercel.app
MIT License
451 stars 95 forks source link

Cannot import picker.css file with webpack import #183

Closed pshurygin closed 5 years ago

pshurygin commented 5 years ago

Hello! I'm importing emoji-mart css using import '@ctrl/ngx-emoji-mart/picker.css'; code, but that does not work for webpack production build, as the import is being removed because of sideEffects: false flag in package.json. Here is an explanation: https://github.com/webpack-contrib/mini-css-extract-plugin/issues/102#issuecomment-384947142 It would be great if the package.json file could be altered as described in that comment, so we do not have to make some dirty workarounds.

To be clear, our projecct does not use cli (we have our own webpack configuration) and we do not import emoji-mart css via sass @import, as importing css files from scss file is considered a deprecated behavior and will be removed in the near future.

scttcper commented 5 years ago

:tada: This issue has been resolved in version 0.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pshurygin commented 5 years ago

@scttcper The latest published version still has sideEffects:false in it's package.json and the issue persists :/ image

scttcper commented 5 years ago

:tada: This issue has been resolved in version 0.11.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: