brankostancevic commented 4 years ago

I just added Emoji's ID to search pull to get results for searching e.g. 'laughing' and 'smiley'. Search functionality now works as non-ngx version of the Emoji Mart module.

codecov[bot] commented 4 years ago

Codecov Report

Merging #328 into master will increase coverage by 1.70%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   57.57%   59.28%   +1.70%     
==========================================
  Files          20       20              
  Lines         726      727       +1     
  Branches      161      161              
==========================================
+ Hits          418      431      +13     
+ Misses        246      233      -13     
- Partials       62       63       +1

Impacted Files	Coverage Δ
src/lib/picker/emoji-search.service.ts	`76.92% <100.00%> (+0.19%)`	:arrow_up:
src/lib/picker/picker.component.ts	`42.07% <0.00%> (+1.98%)`	:arrow_up:
src/lib/picker/category.component.ts	`74.35% <0.00%> (+10.25%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fea5b7...f9ef860. Read the comment docs.

scttcper commented 4 years ago

@brankostancevic thanks for taking care of this!

scttcper commented 4 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

scttcper / ngx-emoji-mart

feat: Emoji ID added to search pool #328

Codecov Report