search

scttcper / qbittorrent

qBittorrent api wrapper
https://qbittorrent.vercel.app
MIT License
43 stars 14 forks source link

feat: Don't delete files by default in removeTorrent #134

Closed sergiou87 closed 2 months ago

sergiou87 commented 2 months ago

According to the documentation: https://github.com/scttcper/qbittorrent/blob/902228cb2b7e3ae5afdbf69c28c272aea2643154/README.md?plain=1#L68

The deleteFiles parameter in removeTorrent should default to false. I have accidentally removed a few downloaded files using this function 😅

The other option is to update the docs to reflect the implementation, but I personally believe the default behavior should be the least destructive.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qbittorrent ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 10:36pm
github-actions[bot] commented 2 months ago

:tada: This issue has been resolved in version 9.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

sergiou87 commented 2 months ago

Thank you for the quick merge @scttcper ! 🙏

Also thank you for this library, because it's been super super useful to me 🍻 🙇‍♂️ Take care!