Add "revision_file" config option to change the name of the revision file

scttnlsn / dandelion

Incremental Git repository deployment.

http://scttnlsn.github.io/dandelion

MIT License

738 stars 60 forks source link

Add "revision_file" config option to change the name of the revision file #11

Closed nickmccurdy closed 12 years ago

nickmccurdy commented 12 years ago

My host blocks the .revision file, and others may as well. ~~This commit changes the name of the revision file to "REVISION"~~ This pull request lets you rename the revision file, letting Dandelion save the revision on the filesystems of hosts that would normally block this file.

However, this was kind of a lazy fix from me, as now the revision file is no longer a hidden file, just to accommodate for certain picky hosts. If you'd like I can instead work on adding an option to Dandelion's config that lets you toggle this functionality, and have it disabled by default. That way most people can get the revision file to be hidden, while people like me who can't use this have an option. This is now a config option which is still ".revision" by default.

scttnlsn commented 12 years ago

Yeah, this would be a nice addition to the config file (default value should be .revision).

nickmccurdy commented 12 years ago

Done. There is now a "revision_file" option in the config file (optional). It defaults to ".revision" and works with any scheme, so by default Dandelion shouldn't do anything differently than it does now. I also updated the readme and diff deployment test to reflect the change.

Notes:

Deployment.initialize now has the following arguments: repo, backend, revision_file, options = {}
This probably won't work unless the revision file is at the root of the directory you're deploying to.
I'm still somewhat new to Ruby and gems, so you should probably check my code to make sure I didn't do anything silly.
I didn't mess with anything for the version number. I'm not sure if I was supposed to.

scttnlsn commented 12 years ago

Lookng good. Let's just pass the revision_file value in the options hash though rather than creating a new parameter.

nickmccurdy commented 12 years ago

Done, how about now?

scttnlsn commented 12 years ago

Thanks. Rebased this in as a single commit.

nickmccurdy commented 12 years ago

Woot, thanks! And you're welcome, glad I could contribute a little.