search

scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 60 forks source link

Net::FTPPermError on deploy #112

Closed frederik-wolf closed 9 years ago

frederik-wolf commented 9 years ago

Hi,

I've been using dandelion for quite some time now and updated just yesterday to the newest version. When deploying onto exisiting wordpress instances (I mostly use dandelion for deploying wordpress to SFTP and FTP) I sometimes get this error:

/home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:327:in getresp': 550 /wp-content/themes/theme/assets/js/production/appfunctions.production.js: No such file or directory (Net::FTPPermError) from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:352:inblock in sendcmd' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/monitor.rb:211:in mon_synchronize' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:350:insendcmd' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:429:in transfercmd' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:544:inblock (2 levels) in storbinary' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:199:in with_binary' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:543:inblock in storbinary' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/monitor.rb:211:in mon_synchronize' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:542:instorbinary' from /home/user/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/net/ftp.rb:691:in putbinaryfile' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/adapter/ftp.rb:31:inblock in write' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/utils.rb:9:in temp' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/adapter/ftp.rb:29:inwrite' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/deployer.rb:49:in deploy_change!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/deployer.rb:13:inblock in deploy_changeset!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/changeset.rb:28:in block in each' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/diff.rb:41:inblock in each' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/diff.rb:37:in each' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/diff.rb:37:ineach' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/changeset.rb:20:in each' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/deployer.rb:9:indeploy_changeset!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/command/deploy.rb:55:in deploy_changeset!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/command/deploy.rb:30:inexecute!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/lib/dandelion/cli.rb:73:in execute!' from /home/user/.rvm/gems/ruby-2.1.2/gems/dandelion-0.4.8/bin/dandelion:8:in<top (required)>' from /home/user/.rvm/gems/ruby-2.1.2/bin/dandelion:23:in load' from /home/user/.rvm/gems/ruby-2.1.2/bin/dandelion:23:in

' from /home/user/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in eval' from /home/user/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in
'

Seems like dandelion doesn't check if the folder exists and just tries to write the file but I'm not sure.

Cheers for this great gem though

scttnlsn commented 9 years ago

That definitely sounds like a regression. I'll take a look. Thanks for reporting!

scttnlsn commented 9 years ago

Please try v0.4.9 and let me know if this issue persists. Thanks!

frederik-wolf commented 9 years ago

Wow that was fast :) I tried it with a simple test commit creating a file in a new folder and it went well. Seems to be good!

scttnlsn commented 9 years ago

Okay, great. Please reopen this issue if the problem persists.