scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 60 forks source link

Login error if ftp password begins with: ! #54

Closed lightfuze closed 10 years ago

lightfuze commented 10 years ago

When trying to deploy using a FTP password that begins with ! the following error occurs:

/Users/user/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/net/ftp.rb:432:in `block in login': 331 Please specify the password. (Net::FTPReplyError)
    from /Users/user/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
    from /Users/user/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/net/ftp.rb:429:in `login'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/backend/ftp.rb:13:in `initialize'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/backend.rb:24:in `new'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/backend.rb:24:in `create'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/command.rb:103:in `backend'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/command.rb:119:in `deployment'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/command/deploy.rb:30:in `execute'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/application.rb:38:in `block in execute'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/command.rb:92:in `initialize'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/application.rb:36:in `new'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/application.rb:36:in `execute'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/lib/dandelion/application.rb:7:in `execute'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/gems/dandelion-0.3.12/bin/dandelion:7:in `<top (required)>'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/bin/dandelion:23:in `load'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/bin/dandelion:23:in `<main>'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:14:in `eval'
    from /Users/user/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:14:in `<main>'
scttnlsn commented 10 years ago

I believe ! is a special character in YAML. Have you tried putting your password in quotes?

lightfuze commented 10 years ago

OK, that explains why other special characters work fine.

Yes, I tried both single and double quotes.

scttnlsn commented 10 years ago

@lightfuze Did you solve the issue? Would you mind sharing?

lightfuze commented 10 years ago

I apparently had not tried enclosing the password in double quotes: "!password" It works just fine.

scttnlsn commented 10 years ago

@lightfuze Ahh, okay. Thanks!