search

scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 60 forks source link

0.4.0.beta2 -- problem with gitignored directory? #69

Closed davidosomething closed 10 years ago

davidosomething commented 10 years ago

My public/content/uploads/ folder is gitignored, not sure what "additional files" are:

Deploying additional files...
Writing file:  public/content/uploads/ -> public/content/uploads/
/Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/deployer.rb:27:in `read': Is a directory @ io_fread - public/content/uploads/ (Errno::EISDIR)
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/deployer.rb:27:in `block in deploy_files!'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/deployer.rb:19:in `each'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/deployer.rb:19:in `deploy_files!'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/command/deploy.rb:63:in `deploy_additional_files!'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/command/deploy.rb:31:in `execute!'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/lib/dandelion/cli.rb:66:in `execute!'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/dandelion-0.4.0.beta2/bin/dandelion:8:in `<top (required)>'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/bin/dandelion:23:in `load'
    from /Users/dotrakoun/.rbenv/versions/2.1.0/bin/dandelion:23:in `<main>'
scttnlsn commented 10 years ago

@davidosomething Do you have "public/content/uploads/" under the additional key in your config file? Did you not have this problem with 0.3.15?

davidosomething commented 10 years ago

Oh yea it is under additional, but I didn't have this problem before.

nitishdhar commented 10 years ago

does the additional key only take individual file path ?

scttnlsn commented 10 years ago

@nitishdhar That's what I expected. Not sure why @davidosomething wasn't having problems previously though.

nitishdhar commented 10 years ago

I have never been able to put directory path in additional files. Anyways, why don't we support directory path in additional files? It would be pretty useful

scttnlsn commented 10 years ago

@nitishdhar Okay, good to know. I agree, this would be nice- I'll work on the feature.

scttnlsn commented 10 years ago

Added: https://github.com/scttnlsn/dandelion/commit/99d3fa67629988605ed4fe1c46b1e51e61020728