search

scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 60 forks source link

add default host to s3 for non us standard endpoints #87

Closed hypernova2002 closed 10 years ago

scttnlsn commented 10 years ago

There's already a host configuration parameter for the S3 adapter.

hypernova2002 commented 10 years ago

The default host still needs to be set, otherwise I receive the error "The bucket you are attempting to access must be addressed using the specified endpoint"

scttnlsn commented 10 years ago

@hypernova2002 Oh, you're right. Looks like an open issue with the aws-s3 gem: https://github.com/marcel/aws-s3/issues/4

How about we just replace the existing options[:server] line with:

AWS::S3::DEFAULT_HOST.replace(@config[:host]) if @config[:host]
hypernova2002 commented 10 years ago

Yes, this works too. I've push up the change.