search

scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 57 forks source link

Rugged gem: "OID too long" error #93

Closed TheLonelyGhost closed 10 years ago

TheLonelyGhost commented 10 years ago

Fixes #92

scttnlsn commented 10 years ago

@TheLonelyGhost Thanks. Looks like some of the specs are failing.

TheLonelyGhost commented 10 years ago

Sorry about that! My pre-commit hooks weren't setup like I thought.

scttnlsn commented 10 years ago

I'd rather not rescue such a generic error since it may become hard to track down other errors that could occur. How about something like:

def remote_sha
  @remote_sha ||= begin
    sha = @adapter.read(@config[:revision_file])
    sha.chomp if sha
  end
end
TheLonelyGhost commented 10 years ago

I thought it was a narrow enough scope (read method of the adapter interface) that it wouldn't be an issue, but I suppose it would cause an error of the second kind in some cases when developing an adapter.

See the latest revision for your proposed correction.

scttnlsn commented 10 years ago

Great- thanks!