scttnlsn / dandelion

Incremental Git repository deployment.
http://scttnlsn.github.io/dandelion
MIT License
738 stars 60 forks source link

Password starting with exclamation mark doesn't work #97

Closed LeaveAirykson closed 10 years ago

LeaveAirykson commented 10 years ago

Hey there, this is a real small issue i think. If the password is starting with an exclamation mark, dandelion doesn't seem to recognize it.

Password set in yml file (sample password):

password: !Testingpass

i get this error:

..ftp.rb:432:in `block in login': 331 User [...] OK. Password required (Net::FTPReplyError)

first i thought the space between the : and the password was causing this, but after removing it i got this:

 could not find expected ':' while scanning a simple key at line 11 column 2 (Psych::SyntaxError)

after removing the exclamation mark, it worked smooth as always.

nitishdhar commented 10 years ago

Hey, put the password inside quotes i.e -

password: "!Testingpass"

It should work.

scttnlsn commented 10 years ago

Exclamations have special meaning in YAML: http://yaml.org/spec/1.1/#id900262

Using quotes like @nitishdhar suggests is the way to go.

LeaveAirykson commented 10 years ago

oh, didn't thought about that! thx!