search

scubacabra / gradle-wsdl-plugin

Gradle plugin that helps with using WSDL files and generating their WARs
GNU General Public License v2.0
12 stars 7 forks source link

added support for generated source encoding property #4

Closed rburgst closed 10 years ago

rburgst commented 10 years ago
scubacabra commented 10 years ago

I am in complete agreement with you.

As I was developing this and using it, it wasn't necessary to include some of these other ones. They weren't default parameters, so I opted to leave them out until I needed them.

With your last pull that fixes that by checking them with some if statements to see if they are specified.

Two other things -- Can you update the README.md with the update from your last pull request and with this update. Please include that these are optional parameters, and are defaulted to not be included unless specifically configured.

Lastly, this diff should be a small change but there is a lot of whitespace changes from reformatting the indentation. Can you clean that up as well please?

rburgst commented 10 years ago

Updated the patch as requested.

scubacabra commented 10 years ago

bintray version 1.7.4 is up as well