scubajeff / lespas

Les Pas, photo album app for Nextcloud user
Apache License 2.0
455 stars 22 forks source link

The audio interferences are back #127

Open yuv opened 1 year ago

yuv commented 1 year ago

Describe the bug The bug is spurious and difficult to reproduce, however, when it starts appearing, it can be reproduced in a cycle. I use Les Pas 2.4.8 from F-Droid, and VLC from F-Droid for the tests.

To Reproduce Steps to reproduce the behavior:

  1. Start an app with audio output (I use VLC)
  2. Start Les Pas, and in the list of albums tap on the first album (Camera Roll is the only album I have)
  3. The volume changes unexpected
  4. get back from the Camera Roll to the list of album and the volume comes back

Expected behavior

Les Pas should not interfere with the volume or the audio output of other apps

Smartphone (please complete the following information):

scubajeff commented 1 year ago

Camera roll is under heavy re-writing now. Hope to fix this in the future release.

yuv commented 1 year ago

Updated to the latest release on F-Droid (v2.9.1). Found the View Setting to disable the screen rotation to match photo aspect ratio. Thanks for that, it fixes my biggest usability beef (the active areas of the screen shifting under my fingers).

This note is to add re: audio interferences: after the recent F-Droid update, the same issue happens with that app too. The O/S has not changed, the two apps have changed. The two apps present this issue in common. Not sure if this has something to do with targeted Android API or what - I am not familiar with the details of Android APIs nor with the two specific apps, just providing this info as it may help zero in on what causes the bug.

For reference: https://gitlab.com/fdroid/fdroidclient/-/issues/2656

scubajeff commented 1 year ago

the two apps have changed

Two apps?

scubajeff commented 1 year ago

I have done some tests following these steps:

  1. Launch music player, start listening to some music, put player into the background, music continuing playing in the background
  2. Launch Les Pas and go to Gallery, or launch Gallery directly using app shortcut
  3. In Gallery's overview screen, click on Camera folder name
  4. In Camera folder view, click any picture/video item in the list
  5. In Photo Slider screen, swipe left and/or right

I tried music player like VLC, Jellyfin, some stock music players. I have tried testing them on various OS levels, namely Android 10, Android 11, Android 13. I tried testing on Android emulator and various phone, like Xiaomi, Sony, 1+ 7 Pro. All the app mentioned are latest version. Unfortunately I can't find a perfect match of your phone for testing, the most closed match is Android emulator running Android 11 and 1+ 7 Pro running latest Android 13.

All the tests when smoothly. In step 2 and 3, the music continuing playing in the background with NO sudden volume change. In step 4, if picture item was clicked, the music continuing playing in the background with NO sudden volume change. If video item is clicked, the background music player stopped, and Les Pas will start to playing audio with current system audio volume. In step 5, flicking through picture items won't stop background music playing and NO sudden volume change. If a video item was swiped in, the background music player stopped and Les Pas will start playing the video with current system audio volume.