search

scullyio / scully

The Static Site Generator for Angular apps
https://scully.io/
MIT License
2.55k stars 256 forks source link

[Discussion] Scully platform-server peerDependencies versioning #1509

Open geromegrignon opened 2 years ago

geromegrignon commented 2 years ago

Description

Current version of Scully platform-server requires Angular peerDependencies to be strictly higher than 12.2.0 :

"peerDependencies": {
    "@angular/common": ">12.2.0",
    "@angular/core": ">12.2.0",
    "@angular/platform-server": ">12.2.0",
    "@scullyio/ng-lib": "x.x.x"
  },

Is there a reason not to include 12.2.0 with >=12.2.0?

It makes creating a new Scully project with nx quite painful as the latest Angular 12 nx-create-workspace version (12.10.2) includes the 12.2.0 Angular version. It means Angular dependencies have to be updated to 12.2.1 or higher before including Scully.

SanderElias commented 2 years ago

@geromegrignon I can't recall a reason for that. I think >12.1 should do it too.