search

scummvm / scummvm-icons

Icons repository for ScummVM rich presence
GNU General Public License v2.0
19 stars 22 forks source link

ICONS: Updating script to handle new spreadsheet id format #309

Closed Thunderforge closed 1 year ago

Thunderforge commented 1 year ago

The spreadsheet will have engine_id:game_id when ScummVM Web #267 is merged.

Only save the game_id, producing the same output as before.

lephilousophe commented 1 year ago

Looks good to me. I only wonder if we should get rid of the engine_id column in the sheet and use the full id to create both fields in the XML (using product_xml.set('engine_id', partition[0]). Maybe it is not wise to remove this column. I don't know at all.

Thunderforge commented 1 year ago

I only wonder if we should get rid of the engine_id column in the sheet and use the full id to create both fields in the XML (using product_xml.set('engine_id', partition[0]).

One advantage to having the engine_id column is validation with the engines sheet (and generated engines.xml). But you're right that it is a bit redundant and aside from that, I don't think there's any real benefit.

I think it's worth exploring in a future PR, but would rather keep the changes small for now and focus on just the game's id.