Some of the Python code might be not run - Githubissues

scunning1975 / mixtape

Data and Program files for Causal Inference: The Mixtape

Other

404 stars 218 forks source link

Some of the Python code might be not run #36

Open saiwing-yeung opened 2 years ago

saiwing-yeung commented 2 years ago

I noticed that some Python code might not run as is. For example, in https://github.com/scunning1975/mixtape/blob/master/python/synth_1.py, it looks like we need:

To import robjects, IntVector, plt
To import pandas2ri and call pandas2ri.activate() so that the dataframe texas would get converted

I have only looked at the code from the synthetic control chapter. I can make a PR for this.