search

scusi / spipe

spipe tools in go
3 stars 1 forks source link

Security Vulnerability Found #1

Closed porcupineyhairs closed 2 years ago

porcupineyhairs commented 2 years ago

Authorization Bypass due to incorrect usage of PAM library

Not using pam_acct_mgmt after pam_authenticate to check the validity of a login can lead to an authorization bypass

Common Weakness Enumeration(CWE) category

CWE - 863

Root Cause Analysis

In this case, in the following PAM transaction, only a call to pam.Authenticate is used to login a user.

https://lgtm.com/projects/g/scusi/spipe/snapshot/2679a0ecc0e6e2900cf93a348baf1e61812e7252/files/shells/LoginShell/spipeLoginBindShell.go#x84b6005da3b7b4bc:1

This implies that a user with expired credentials can still login.

The bug can be verified easily by creating a new user account, expiring it with chage -E0 username and then trying to log in with the expired credentials.

Remediation

This can be fixed by invoking a call to pam.AcctMgmt after a successful call to pam.Authenticate

Common Vulnerability Scoring System Vector

Exploitability

The attack can be carried over the network. A complex non-standard configuration or a specialized condition is required for the attack to be successfully conducted. The attacker also requires access to a users credentials, be it expired, for an attack to be successful. There is no user interaction required for successful execution. The attack can affect components outside the scope of the target module.

Impact

Using this attack vector, an attacker may access otherwise restricted parts of the system. The attack can be used to gain access to confidential files like passwords, login credentials and other secrets. Hence, it has a high impact on confidentiality. It may also be directly used to affect a change on a system resource. Hence has a medium to high impact on integrity. This attack may not be used to affect the availability of the system. Taking this account an appropriate CVSS v3.1 vector would be

(AV:N/AC:H/PR:L/UI:N/S:C/C:H/I:L/A:N)[https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:N/A:L&version=3.1]

This gives it a base score of 7.7/10 and a severity rating of high.

References

This bug was found using CodeQL by Github

porcupineyhairs commented 2 years ago

@scusi I can see you have already fixed this issue via afc55ed73bdf138634a5dac71b0e1369bf6babb6. Hence, I am closing this PR as well as the corresponding issue.