scverse / anndata

Annotated data.
http://anndata.readthedocs.io
BSD 3-Clause "New" or "Revised" License
521 stars 149 forks source link

(chore): change boolean settings names to use `should` #1509

Closed ilan-gold closed 4 weeks ago

ilan-gold commented 1 month ago

Since this is coming in 0.11 I think we should change these to use should verbs at the front. I like verbs in front of booleans because it makes clear what they do. Otherwise, I would just close them and leave them both as the action without should

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.29%. Comparing base (cc07a91) to head (159512d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ig/uniqueness_check #1509 +/- ## ==================================================== Coverage 84.29% 84.29% ==================================================== Files 35 35 Lines 5698 5698 ==================================================== Hits 4803 4803 Misses 895 895 ``` | [Files](https://app.codecov.io/gh/scverse/anndata/pull/1509?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/anndata/\_core/anndata.py](https://app.codecov.io/gh/scverse/anndata/pull/1509?src=pr&el=tree&filepath=src%2Fanndata%2F_core%2Fanndata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL2FubmRhdGEvX2NvcmUvYW5uZGF0YS5weQ==) | `84.98% <100.00%> (ø)` | | | [src/anndata/\_settings.py](https://app.codecov.io/gh/scverse/anndata/pull/1509?src=pr&el=tree&filepath=src%2Fanndata%2F_settings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL2FubmRhdGEvX3NldHRpbmdzLnB5) | `95.00% <100.00%> (ø)` | |