scverse / anndata

Annotated data.
http://anndata.readthedocs.io
BSD 3-Clause "New" or "Revised" License
577 stars 154 forks source link

Potentially flaky benchmark #1513

Open ilan-gold opened 5 months ago

ilan-gold commented 5 months ago

Please make sure these conditions are met

Report

It seems that one of the benchmarks could be flaky: https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25740561547 because I changed almost nothing except a different benchmark name and then it reverted to passing: https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25777680830. The benchmark is readwrite.H5ADReadSuite.track_read_full_memratio('pbmc3k')

Versions

N/A
ilan-gold commented 5 months ago

https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25779040354 Now back to failing...maybe it's this branch then

flying-sheep commented 3 months ago

The benchmarks in general seem to be flaky.

We should check out the machine together and see how we can tune it to be more consistent

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. Please add a comment if you want to keep the issue open. Thank you for your contributions!