search

scverse / anndata

Annotated data.
http://anndata.readthedocs.io
BSD 3-Clause "New" or "Revised" License
570 stars 152 forks source link

(fix): allow setting `X` as sparse when `X` is dense view #1532

Closed ilan-gold closed 3 months ago

ilan-gold commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.43%. Comparing base (f7de3ba) to head (50a909e). Report is 71 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1532 +/- ## ======================================= Coverage 84.43% 84.43% ======================================= Files 36 36 Lines 5742 5745 +3 ======================================= + Hits 4848 4851 +3 Misses 894 894 ``` | [Files with missing lines](https://app.codecov.io/gh/scverse/anndata/pull/1532?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/anndata/\_core/anndata.py](https://app.codecov.io/gh/scverse/anndata/pull/1532?src=pr&el=tree&filepath=src%2Fanndata%2F_core%2Fanndata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL2FubmRhdGEvX2NvcmUvYW5uZGF0YS5weQ==) | `84.78% <100.00%> (+0.05%)` | :arrow_up: |
ilan-gold commented 3 months ago

@flying-sheep I guess I just wasn't even sure this was the desired result but your approval says that we are on the right track. I will add a warning.