search

scverse / genomic-features

Genomic Features in Python from BioConductor's AnnotationHub
https://genomic-features.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

Add more filters #31

Closed ivirshup closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #31 (720b721) into main (eca1342) will increase coverage by 0.91%. The diff coverage is 97.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== + Coverage 92.02% 92.94% +0.91% ========================================== Files 6 6 Lines 276 312 +36 ========================================== + Hits 254 290 +36 Misses 22 22 ``` | [Impacted Files](https://app.codecov.io/gh/scverse/genomic-features/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse) | Coverage Δ | | |---|---|---| | [src/genomic\_features/filters.py](https://app.codecov.io/gh/scverse/genomic-features/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL2dlbm9taWNfZmVhdHVyZXMvZmlsdGVycy5weQ==) | `100.00% <ø> (ø)` | | | [src/genomic\_features/\_core/filters.py](https://app.codecov.io/gh/scverse/genomic-features/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse#diff-c3JjL2dlbm9taWNfZmVhdHVyZXMvX2NvcmUvZmlsdGVycy5weQ==) | `92.75% <97.22%> (+1.57%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scverse/genomic-features/pull/31/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse)
ivirshup commented 1 year ago

Overall, I think this is pretty simple, but I wasn't sure what CanonicalFilter should be called