Closed emdann closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merging #32 (4bd3181) into main (8e336e9) will increase coverage by
1.03%
. The diff coverage is95.83%
.
I tried it and it looks good to me! One point: Will we have one ranges filter for each genes, transcripts etc.? Otherwise, we will have to think about how we set the columns correctly
@lauradmartens, good point. I think it makes sense to have separate filters, since that let's you specify "get all exons for any gene in this range".
Since we'll tweet a link to the docs later today, and I'd like to have this merged, I went ahead and made a couple changes:
Happy to revert any of these, but wanted genomic range functionality in the demo
I think it would make sense to rename the "main coordinates" in every table (as discussed here https://github.com/scverse/genomic-features/issues/33) for more general filter function and compatibility with bioframe
Added
RangesFilter
to subset gene annotations in a specific range, filtering by any overlap or annotations within a range.