search

scverse / genomic-features

Genomic Features in Python from BioConductor's AnnotationHub
https://genomic-features.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

Add Chip_seq_genomic_ranges_tutorial #65

Closed vmuckerson closed 2 months ago

vmuckerson commented 3 months ago

Added a tutorial for aligning ensembl db annotations and chip-seq data from ENCODE. Also includes bio frame capabilities and genome features filtering example.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.94%. Comparing base (ef33d87) to head (ee9edbc). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== - Coverage 93.09% 92.94% -0.16% ========================================== Files 6 6 Lines 333 340 +7 ========================================== + Hits 310 316 +6 - Misses 23 24 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/scverse/genomic-features/pull/65/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scverse)
ivirshup commented 3 months ago

I've pushed a commit that should make the docs render

ivirshup commented 3 months ago

@vmuckerson, is this the notebook you are currently working on, or is this ready for review/ merging?

vmuckerson commented 3 months ago

@ivirshup This should now be ready for review/merging!

lauradmartens commented 3 months ago

Thanks a lot for the great contribution! I left a few comments!

vmuckerson commented 2 months ago

Thank you both for reviewing @ivirshup @lauradmartens ! I hope I addressed all of your comments, please let me know if there's anything else that should be changed or if anything remains unclear.