Closed gtca closed 2 years ago
This is how the speed-up looks for the script attached (MuData of size 100 x 600_000
):
# master*
> python update-1.py
Creation time: 11.650s
Update time: 15.865s
# update-1*
> python update-1.py
Creation time: 0.886s
Update time: 0.931s
Maybe add a test for partially intersecting obs_names
? I believe that we hit a bug in that recently. Otherwise, LGTM.
Addresses #16.
When attr_names (typically var_names) are unique and not intersecting between modalities, this should greatly improve the speed of the
mdata.update()
.